New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: deprecate verify --cert
#151
base: main
Are you sure you want to change the base?
Conversation
The long form (`--certificate`) is the intended option. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
As a demo: $ sigstore verify --cert README.md.crt README.md
WARNING:sigstore._cli:--cert has been replaced with --certificate and will be removed in an upcoming stable release |
Does I'll leave the judgement call to you but I tend to think that it's more important that our CLI is compatible with |
Yeah, that's why I wanted to get @di's opinion -- IMO we're divergent enough at this point that it makes sense to make changes that improve our UX, but this is admittedly a very small example of one of those changes 🙂 |
I think we should just support both as the same option for now, with no deprecation warning, to ensure this remains intuitive for |
Sounds good. I'll mark this as a draft then, and we can revisit if necessary. |
The long form (
--certificate
) is the intended option.Closes #149.
Signed-off-by: William Woodruff william@trailofbits.com