Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigstore: uniform user-agent with sigstore version #1008

Merged
merged 4 commits into from May 13, 2024
Merged

sigstore: uniform user-agent with sigstore version #1008

merged 4 commits into from May 13, 2024
+24 −3

Conversation

woodruffw
Copy link
Member

This sets the UA in the Fulcio, Rekor, and OIDC clients. I haven't touched the TUF client since I wasn't sure how to access the underlying requests.Session there 🙂

See #985.

@woodruffw
sigstore: uniform user-agent with sigstore version
f3311e1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added this to the 3.0 milestone May 9, 2024
@woodruffw woodruffw requested a review from jku May 9, 2024 18:45
@woodruffw woodruffw self-assigned this May 9, 2024
@woodruffw woodruffw mentioned this pull request May 9, 2024
Closed
4 tasks
jku
jku approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@jku jku left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will make load balancer logs a little easier to figure out and gives us a tiny bit of telemetry (which versions of sigstore-python are being used in the wild)

I'll handle tuf when 4.1 is released.

@woodruffw woodruffw enabled auto-merge (squash) May 13, 2024 13:02
@woodruffw woodruffw merged commit 87c4b66 into main May 13, 2024
24 checks passed
@woodruffw woodruffw deleted the ww/ua branch May 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woodruffw @jku