Revert "use ecdsa for keytype. But when signing, support both formats" #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
approved these changes
Mar 1, 2024
bobcallaway
approved these changes
Mar 1, 2024
|
Oh, yes of course 🤦 |
|
@haydentherapper what I can think of is that we expose a parameter flag that is set in the workflows to use the older key type, then as part of the signing ceremony we update the workflow to not set the flag and so use the new type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1130
Fixes #1139
Breaks snapshot and timestamp generation at main, since the key ID calculation changed. Will merge back in closer to signing ceremony.
Will take a look on Monday to see if there’s another way to set this up so it can be immediately merged back.