Run e2e Go tests first. #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect why the e2e tests are failing is because we're running this after the staging tests when the sigstore root has been changed to staging. Current the tests hardcode prod sigstore, which is likely what is causing the issues since we're trying to verify a prod signature with the staging root. TBD if this is the right thing to do (or if we should use staging instead), but this should hopefully fix us for the time being.
|
e2e tests will fail until this is submitted, since pull_request_target pulls from main |
cpanato
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I suspect why the e2e tests are failing is because we're running this after the staging tests when the sigstore root has been changed to staging.
Current the tests hardcode prod sigstore, which is likely what is causing the issues since we're trying to verify a prod signature with the staging root. TBD if this is the right thing to do (or if we should use staging instead), but this should hopefully fix us for the time being.
Release Note
NONE
Documentation