Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI updates and fix lints #461

Merged
merged 4 commits into from Mar 4, 2024
Merged

CI updates and fix lints #461

merged 4 commits into from Mar 4, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 4, 2024 •
edited

Summary

  • drop enable auto emrge, due that does not trigger ci when merge
  • bump golangci-lint to v1.56.x
  • fix lints

@cpanato cpanato changed the title CI updates CI updates, update tests and fix lints Mar 4, 2024
@cpanato cpanato force-pushed the fix branch 2 times, most recently from ef74c77 to b22c9de Compare March 4, 2024 11:11
@cpanato
Copy link
Member Author

cpanato commented Mar 4, 2024

getting this

sign_test.go:113: failed to verify detached signature: x509: certificate signed by unknown authority (possibly because of "x509: ECDSA verification failure" while trying to verify candidate authority certificate "sigstore-intermediate")

any tips in how to fix this @wlynch ?

@cpanato cpanato requested a review from wlynch March 4, 2024 11:15
@cpanato
drop enable auto emrge, due that does not trigger ci when merge
ebbd604 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
bump golangci-lint to v1.56.x
0ad712a 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
fix lints
f6f9ecb 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
update dependencies
b58a9f8 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato changed the title CI updates, update tests and fix lints CI updates and fix lints Mar 4, 2024
@wlynch wlynch enabled auto-merge (squash) March 4, 2024 14:20
@wlynch wlynch merged commit c2ac22d into sigstore:main Mar 4, 2024
7 checks passed
@cpanato cpanato deleted the fix branch March 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpanato @wlynch