Add support for repository evironments #138
Conversation
main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| userId, err := strconv.Atoi(user.Id) |
There was a problem hiding this comment.
this seems fishy to me -- why is the user.Id a string but then RepositoryEnvironmentReviewerArray takes an int array as argument?
There was a problem hiding this comment.
Maybe a difference between the GitHub interface returning strings but pulumi's API assuming IDs are ints?
main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| userId, err := strconv.Atoi(user.Id) |
There was a problem hiding this comment.
Maybe a difference between the GitHub interface returning strings but pulumi's API assuming IDs are ints?
|
long term I wonder if the approach taken in this repo is maintainable: It's Configuration-as-Code sure... but it's a lot of code. Do we really want to maintain all of this -- what is so special about sigstore CaC that we need to write our own programs for it? Someone more experienced with this could maybe estimate how this compares to switching the whole system to pulumi yaml (https://www.pulumi.com/docs/languages-sdks/yaml/)? It seems like this would
the cost would be translating sigstore-community to pulumi yaml format. |
|
@cpanato did you have thoughts on the above? Is there much difference between our current configuration language and pulumis? |
This allows projects to do things like * require deployment reviews * Ensure deployments come from defined set of branches/tags Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Add support for repository (deployment) environments.
This likely needs a bit of work still (I still don't fully know what I'm doing with golang and pulumi API is a bit strange). This code has also never been executed yet.