Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Support for Fulcio Client Credentials Flow, and Argument to Set Flow Explicitly #3578

Merged
merged 3 commits into from Mar 12, 2024

Conversation

nkreiger
Copy link
Contributor

@nkreiger nkreiger commented Mar 7, 2024

Summary

Implements this:

sigstore/sigstore#1619


It looks like the flag was also missing from the CLI ko.KeyOpts to set the fulcio flow explicitly. Should be 100% backwards compatible because the default was always an empty string.

Release Note

  • Command Flag Addition - --fulcio-auth-flow to explicitly set the fulcio authentication flow
  • API Addition, support for --fulcio-auth-flow=client_credentials as an authentication flow. Requires the Client ID and Client Secret.

Documentation

cosign sign --fulcio_url=<url> --fulcio-auth-flow=client_credentials --client-secret=<secret file> --client-id=sigstore

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 39.94%. Comparing base (2ef6022) to head (2acc28b).
Report is 39 commits behind head on main.

Files Patch % Lines
cmd/cosign/cli/options/fulcio.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/fulcio/fulcio.go 0.00% 2 Missing ⚠️
cmd/cosign/cli/attest.go 0.00% 1 Missing ⚠️
cmd/cosign/cli/attest_blob.go 0.00% 1 Missing ⚠️
cmd/cosign/cli/sign.go 0.00% 1 Missing ⚠️
cmd/cosign/cli/signblob.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
- Coverage   40.10%   39.94%   -0.17%     
==========================================
  Files         155      155              
  Lines       10044    10087      +43     
==========================================
+ Hits         4028     4029       +1     
- Misses       5530     5584      +54     
+ Partials      486      474      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobcallaway
Copy link
Member

also, please rebase now that #3579 has merged.

Signed-off-by: Noah Kreiger <noahkreiger@gmail.com>
Signed-off-by: Noah Kreiger <noahkreiger@gmail.com>
Signed-off-by: Noah Kreiger <noahkreiger@gmail.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bobcallaway bobcallaway merged commit 5d60a9a into sigstore:main Mar 12, 2024
29 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants