Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for custom callbacks, various fixes and improvements #67

Merged
merged 11 commits into from May 5, 2023

Conversation

pagmatt
Copy link
Member

@pagmatt pagmatt commented Apr 26, 2023

This PR adds the support for defining custom callbacks, with the main use case in mind the notification of simulation progress, for instance via a Telegram bot.
The base callback class is inspired by stable-baselines3

Moreover:

  • Switched to ThreadPool to Pool to support callbacks as member variables
  • Improved documentation coverage

pagmatt and others added 11 commits February 22, 2023 09:20
Improve parameters support of the callbacks

- adaptation of parallelrunner.py to support all versions of Python
- minor bugs fixed
- ad hoc test implementation
---------

Co-authored-by: pagmatt <mattpagg@gmail.com>
Co-authored-by: Andrea Lacava <lacava.a@norhteastern.edu>
@pagmatt pagmatt requested a review from DvdMgr April 26, 2023 19:08
@pagmatt pagmatt added the enhancement New feature or request label Apr 26, 2023
@pagmatt pagmatt merged commit 1aaa051 into master May 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants