-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mod_avmd] exposing more parameters to config #2418
Closed
evgeniibuchnev
wants to merge
11
commits into
signalwire:master
from
evgeniibuchnev:mod_avmd_expose_more_parameters
Closed
[mod_avmd] exposing more parameters to config #2418
evgeniibuchnev
wants to merge
11
commits into
signalwire:master
from
evgeniibuchnev:mod_avmd_expose_more_parameters
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniibuchnev
commented
Apr 3, 2024
- Exposing previously hardcoded parameters in mod_avmd.c to be configurable, this would allow fine-tuning mod_avmd to suite wider needs.
- AVMD_MIN_FREQUENCY
- AVMD_MAX_FREQUENCY
- AVMD_MIN_AMP
- AVMD_VARIANCE_RSD_THRESHOLD
- AVMD_AMPLITUDE_RSD_THRESHOLD
- Updated default avmd.conf.xml to have default values for new exposed parameters.
1. Exposing previously hardcoded parameters in mod_avmd.c to be configurable, this would allow fine-tuning mod_avmd to suite wider needs. - AVMD_MIN_FREQUENCY - AVMD_MAX_FREQUENCY - AVMD_MIN_AMP - AVMD_VARIANCE_RSD_THRESHOLD - AVMD_AMPLITUDE_RSD_THRESHOLD 2. Updated default avmd.conf.xml to have default values for new exposed parameters.
Hey Team,
|
evgeniibuchnev
force-pushed
the
mod_avmd_expose_more_parameters
branch
from
May 22, 2024 04:29
3300c41
to
da529bb
Compare
Added clean PR #2468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.