Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined the master and base docker images to create an updated, minimized image #2378

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

king-dopey
Copy link

Most of the concepts are taken from the docker images in the master and base_image folders. It's now all done in one Dockerfile, using buildkit and a staging image. It also includes build hooks so the Token can be added as an environment variable, on Docker Hub, for automated builds and security scans.
Other enhancements to the updated docker image:

  1. Moved from from tar to cp and shell scripting for consistency and correct racing conditions documented in the shell script
  2. Added erlang-base, curl, and ca-certificates
  3. Copied ca-certificates, so Curl functions properly (including internally to freeswitch)
  4. Fixed sound file downloading
  5. Increased the complexity of the default generated password
  6. Merged sudo process, but moved to su-exec from gosu, to clear vulnerabilities
  7. Update Debian distro before freeswitch install, to keep dependencies fully up to date
  8. Updated to the latest Busybox

This is currently being auto-built at https://hub.docker.com/r/dheaps/freeswitch.

… and dependency only) image based and the latest Debian images

Moved from from tar to cp and shell scripting for consistency and correct racing conditions documented in the shell script
Added erlang-base, curl, and ca-certificates
Copied ca-certificates, so Curl functions properly (including internally to freeswitch)
Fixed sound file downloading
Increased the complexity of the default generated password
Merged sudo process, but moved to su-exec from gosu, to clear vulnerabilities
Update Debian distro before freeswitch install, to keep dependencies fully up to date
Updated to the latest Busybox
latest has minimal dependencies
python includes python
perl includes perl
java includes java
full includes python perl and java
Also added additional openssl dependencies to all images
@signalwire-ci
Copy link

signalwire-ci bot commented Feb 13, 2024

@king-dopey
Copy link
Author

The PR drone seem to consistently fail when another commit is added to the PR, on the notify step, not on an actual test. Anyhow, those unit tests are irrelevant to this PR and no code being tested was updated.

@signalwire-ci
Copy link

signalwire-ci bot commented Apr 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant