Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest otel snapshot #4507

Merged
merged 1 commit into from Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
330 changes: 168 additions & 162 deletions go.mod

Large diffs are not rendered by default.

673 changes: 338 additions & 335 deletions go.sum

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions internal/components/components_test.go
Expand Up @@ -25,7 +25,7 @@ import (
)

func TestDefaultComponents(t *testing.T) {
expectedExtensions := []component.Type{
expectedExtensions := []string{
"basicauth",
"ecs_observer",
"ecs_task_observer",
Expand All @@ -40,7 +40,7 @@ func TestDefaultComponents(t *testing.T) {
"memory_ballast",
"file_storage",
}
expectedReceivers := []component.Type{
expectedReceivers := []string{
"azureeventhub",
"carbon",
"cloudfoundry",
Expand Down Expand Up @@ -88,7 +88,7 @@ func TestDefaultComponents(t *testing.T) {
"windowsperfcounters",
"zipkin",
}
expectedProcessors := []component.Type{
expectedProcessors := []string{
"attributes",
"batch",
"cumulativetodelta",
Expand All @@ -107,7 +107,7 @@ func TestDefaultComponents(t *testing.T) {
"timestamp",
"transform",
}
expectedExporters := []component.Type{
expectedExporters := []string{
"awss3",
"debug",
"file",
Expand All @@ -122,7 +122,7 @@ func TestDefaultComponents(t *testing.T) {
"splunk_hec",
"httpsink",
}
expectedConnectors := []component.Type{
expectedConnectors := []string{
"count",
"routing",
"spanmetrics",
Expand All @@ -135,40 +135,40 @@ func TestDefaultComponents(t *testing.T) {
exts := factories.Extensions
assert.Len(t, exts, len(expectedExtensions))
for _, k := range expectedExtensions {
v, ok := exts[k]
v, ok := exts[component.MustNewType(k)]
assert.True(t, ok)
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.Type().String())
}

recvs := factories.Receivers
assert.Len(t, recvs, len(expectedReceivers))
for _, k := range expectedReceivers {
v, ok := recvs[k]
v, ok := recvs[component.MustNewType(k)]
require.True(t, ok)
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.Type().String())
}

procs := factories.Processors
assert.Len(t, procs, len(expectedProcessors))
for _, k := range expectedProcessors {
v, ok := procs[k]
v, ok := procs[component.MustNewType(k)]
require.True(t, ok, fmt.Sprintf("Missing expected processor %s", k))
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.Type().String())
}

exps := factories.Exporters
assert.Len(t, exps, len(expectedExporters))
for _, k := range expectedExporters {
v, ok := exps[k]
v, ok := exps[component.MustNewType(k)]
require.True(t, ok)
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.Type().String())
}

conns := factories.Connectors
assert.Len(t, conns, len(expectedConnectors))
for _, k := range expectedConnectors {
v, ok := conns[k]
v, ok := conns[component.MustNewType(k)]
require.True(t, ok, fmt.Sprintf("Missing expected connector %s", k))
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.Type().String())
}
}
2 changes: 1 addition & 1 deletion internal/configsource/envvarconfigsource/config_test.go
Expand Up @@ -34,7 +34,7 @@ func TestEnvVarConfigSourceLoadConfig(t *testing.T) {
require.NoError(t, err)

factories := map[component.Type]configsource.Factory{
typeStr: NewFactory(),
component.MustNewType(typeStr): NewFactory(),
}

actualSettings, splitConf, err := configsource.SettingsFromConf(context.Background(), v, factories, nil)
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/envvarconfigsource/factory.go
Expand Up @@ -32,7 +32,7 @@ const (
type envVarFactory struct{}

func (e *envVarFactory) Type() component.Type {
return typeStr
return component.MustNewType(typeStr)
}

func (e *envVarFactory) CreateDefaultConfig() configsource.Settings {
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/etcd2configsource/config_test.go
Expand Up @@ -34,7 +34,7 @@ func TestEtcd2LoadConfig(t *testing.T) {
require.NoError(t, err)

factories := map[component.Type]configsource.Factory{
typeStr: NewFactory(),
component.MustNewType(typeStr): NewFactory(),
}

actualSettings, splitConf, err := configsource.SettingsFromConf(context.Background(), v, factories, nil)
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/etcd2configsource/factory.go
Expand Up @@ -42,7 +42,7 @@ type (
type etcd2Factory struct{}

func (v *etcd2Factory) Type() component.Type {
return typeStr
return component.MustNewType(typeStr)
}

func (v *etcd2Factory) CreateDefaultConfig() configsource.Settings {
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/includeconfigsource/config_test.go
Expand Up @@ -35,7 +35,7 @@ func TestIncludeConfigSourceLoadConfig(t *testing.T) {
require.NoError(t, err)

factories := map[component.Type]configsource.Factory{
typeStr: NewFactory(),
component.MustNewType(typeStr): NewFactory(),
}

actualSettings, splitConf, err := configsource.SettingsFromConf(context.Background(), v, factories, nil)
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/includeconfigsource/factory.go
Expand Up @@ -32,7 +32,7 @@ const (
type includeFactory struct{}

func (f *includeFactory) Type() component.Type {
return typeStr
return component.MustNewType(typeStr)
}

func (f *includeFactory) CreateDefaultConfig() configsource.Settings {
Expand Down
4 changes: 2 additions & 2 deletions internal/configsource/settings_test.go
Expand Up @@ -31,7 +31,7 @@ func TestConfigSourceParser(t *testing.T) {
ctx := context.Background()

testFactories := Factories{
"tstcfgsrc": &MockCfgSrcFactory{},
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{},
}
tests := []struct {
factories Factories
Expand Down Expand Up @@ -91,7 +91,7 @@ func TestConfigSourceParser(t *testing.T) {
name: "missing_factory",
file: "basic_config",
factories: Factories{
"not_in_basic_config": &MockCfgSrcFactory{},
component.MustNewType("not_in_basic_config"): &MockCfgSrcFactory{},
},
wantErr: "unknown config_sources type \"tstcfgsrc\"",
},
Expand Down
14 changes: 7 additions & 7 deletions internal/configsource/source_test.go
Expand Up @@ -52,7 +52,7 @@ func TestConfigSourceManagerNewManager(t *testing.T) {
name: "basic_config",
file: "basic_config",
factories: Factories{
"tstcfgsrc": &MockCfgSrcFactory{},
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{},
},
},
{
Expand All @@ -65,7 +65,7 @@ func TestConfigSourceManagerNewManager(t *testing.T) {
name: "build_error",
file: "basic_config",
factories: Factories{
"tstcfgsrc": &MockCfgSrcFactory{
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{
ErrOnCreateConfigSource: errors.New("forced test error"),
},
},
Expand Down Expand Up @@ -657,7 +657,7 @@ func callClose(closeFunc confmap.CloseFunc) error {
func TestConfigSourceBuild(t *testing.T) {
ctx := context.Background()
testFactories := Factories{
"tstcfgsrc": &MockCfgSrcFactory{},
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{},
}

tests := []struct {
Expand Down Expand Up @@ -685,7 +685,7 @@ func TestConfigSourceBuild(t *testing.T) {
},
},
factories: Factories{
"tstcfgsrc": &MockCfgSrcFactory{
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{
ErrOnCreateConfigSource: errors.New("forced test error"),
},
},
Expand All @@ -699,7 +699,7 @@ func TestConfigSourceBuild(t *testing.T) {
},
},
factories: Factories{
"tstcfgsrc": &mockNilCfgSrcFactory{},
component.MustNewType("tstcfgsrc"): &mockNilCfgSrcFactory{},
},
wantErr: "factory for \"tstcfgsrc\" produced a nil extension",
},
Expand Down Expand Up @@ -745,7 +745,7 @@ func TestConfigSourceBuild(t *testing.T) {
type mockNilCfgSrcFactory struct{}

func (m *mockNilCfgSrcFactory) Type() component.Type {
return "tstcfgsrc"
return component.MustNewType("tstcfgsrc")
}

var _ (Factory) = (*mockNilCfgSrcFactory)(nil)
Expand Down Expand Up @@ -776,7 +776,7 @@ var _ Settings = (*MockCfgSrcSettings)(nil)
var _ Factory = (*MockCfgSrcFactory)(nil)

func (m *MockCfgSrcFactory) Type() component.Type {
return "tstcfgsrc"
return component.MustNewType("tstcfgsrc")
}

func (m *MockCfgSrcFactory) CreateDefaultConfig() Settings {
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/vaultconfigsource/config_test.go
Expand Up @@ -35,7 +35,7 @@ func TestVaultLoadConfig(t *testing.T) {
require.NoError(t, err)

factories := map[component.Type]configsource.Factory{
typeStr: NewFactory(),
component.MustNewType(typeStr): NewFactory(),
}

actualSettings, splitConf, err := configsource.SettingsFromConf(context.Background(), v, factories, nil)
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/vaultconfigsource/factory.go
Expand Up @@ -49,7 +49,7 @@ type (
type vaultFactory struct{}

func (v *vaultFactory) Type() component.Type {
return typeStr
return component.MustNewType(typeStr)
}

func (v *vaultFactory) CreateDefaultConfig() configsource.Settings {
Expand Down
Expand Up @@ -35,7 +35,7 @@ func TestZookeeperLoadConfig(t *testing.T) {
require.NoError(t, err)

factories := map[component.Type]configsource.Factory{
typeStr: NewFactory(),
component.MustNewType(typeStr): NewFactory(),
}

actualSettings, splitConf, err := configsource.SettingsFromConf(context.Background(), v, factories, nil)
Expand Down
2 changes: 1 addition & 1 deletion internal/configsource/zookeeperconfigsource/factory.go
Expand Up @@ -38,7 +38,7 @@ type errMissingEndpoint struct{ error }
type zkFactory struct{}

func (v *zkFactory) Type() component.Type {
return typeStr
return component.MustNewType(typeStr)
}

func (v *zkFactory) CreateDefaultConfig() configsource.Settings {
Expand Down
12 changes: 6 additions & 6 deletions internal/confmapprovider/configsource/provider_test.go
Expand Up @@ -54,23 +54,23 @@ func TestConfigSourceConfigMapProvider(t *testing.T) {
{
name: "new_manager_builder_error",
factories: configsource.Factories{
"tstcfgsrc": &MockCfgSrcFactory{
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{
ErrOnCreateConfigSource: errors.New("new_manager_builder_error forced error"),
},
},
parserProvider: fileprovider.New(),
parserProvider: fileprovider.NewWithSettings(confmap.ProviderSettings{}),
uris: []string{"file:" + path.Join("testdata", "basic_config.yaml")},
wantErr: "failed to create config source tstcfgsrc",
},
{
name: "manager_resolve_error",
parserProvider: fileprovider.New(),
parserProvider: fileprovider.NewWithSettings(confmap.ProviderSettings{}),
uris: []string{"file:" + path.Join("testdata", "manager_resolve_error.yaml")},
wantErr: "config source \"tstcfgsrc\" failed to retrieve value: no value for selector \"selector\"",
},
{
name: "multiple_config_success",
parserProvider: fileprovider.New(),
parserProvider: fileprovider.NewWithSettings(confmap.ProviderSettings{}),
uris: []string{"file:" + path.Join("testdata", "arrays_and_maps_expected.yaml"),
"file:" + path.Join("testdata", "yaml_injection_expected.yaml")},
},
Expand All @@ -80,7 +80,7 @@ func TestConfigSourceConfigMapProvider(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
if tt.factories == nil {
tt.factories = configsource.Factories{
"tstcfgsrc": &MockCfgSrcFactory{},
component.MustNewType("tstcfgsrc"): &MockCfgSrcFactory{},
}
}

Expand Down Expand Up @@ -212,7 +212,7 @@ var _ configsource.Settings = (*MockCfgSrcSettings)(nil)
var _ configsource.Factory = (*MockCfgSrcFactory)(nil)

func (m *MockCfgSrcFactory) Type() component.Type {
return "tstcfgsrc"
return component.MustNewType("tstcfgsrc")
}

func (m *MockCfgSrcFactory) CreateDefaultConfig() configsource.Settings {
Expand Down
12 changes: 6 additions & 6 deletions internal/confmapprovider/discovery/discoverer.go
Expand Up @@ -59,8 +59,8 @@ const (
)

var (
yamlProvider = yamlprovider.New()
envProvider = envprovider.New()
yamlProvider = yamlprovider.NewWithSettings(confmap.ProviderSettings{})
envProvider = envprovider.NewWithSettings(confmap.ProviderSettings{})
)

// discoverer provides the mechanism for a "preflight" collector service
Expand Down Expand Up @@ -459,10 +459,10 @@ func (d *discoverer) updateReceiverForObserver(receiverID component.ID, receiver

func factoryForObserverType(extType component.Type) (otelcolextension.Factory, error) {
factories := map[component.Type]otelcolextension.Factory{
"docker_observer": dockerobserver.NewFactory(),
"host_observer": hostobserver.NewFactory(),
"k8s_observer": k8sobserver.NewFactory(),
"ecs_task_observer": ecstaskobserver.NewFactory(),
component.MustNewType("docker_observer"): dockerobserver.NewFactory(),
component.MustNewType("host_observer"): hostobserver.NewFactory(),
component.MustNewType("k8s_observer"): k8sobserver.NewFactory(),
component.MustNewType("ecs_task_observer"): ecstaskobserver.NewFactory(),
}
ef, ok := factories[extType]
if !ok {
Expand Down
2 changes: 1 addition & 1 deletion internal/exporter/httpsinkexporter/factory.go
Expand Up @@ -32,7 +32,7 @@ const (
// NewFactory creates a factory for httpsink exporter.
func NewFactory() exporter.Factory {
return exporter.NewFactory(
typeStr,
component.MustNewType(typeStr),
createDefaultConfig,
exporter.WithMetrics(createMetricsExporter, component.StabilityLevelDevelopment),
exporter.WithTraces(createTracesExporter, component.StabilityLevelDevelopment),
Expand Down
4 changes: 2 additions & 2 deletions internal/receiver/discoveryreceiver/config.go
Expand Up @@ -98,7 +98,7 @@ func (cfg *Config) Validate() error {
var err error
for rName, rEntry := range cfg.Receivers {
name := rName.String()
if rName.Type() == "receiver_creator" {
if rName.Type() == component.MustNewType("receiver_creator") {
err = multierr.Combine(err, fmt.Errorf("receiver %q validation failure: receiver cannot be a receiver_creator", name))
continue
}
Expand Down Expand Up @@ -209,7 +209,7 @@ func (cfg *Config) receiverCreatorReceiversConfig(correlations correlationStore)
resourceAttributes[k] = v
}
resourceAttributes[discovery.ReceiverNameAttr] = receiverID.Name()
resourceAttributes[discovery.ReceiverTypeAttr] = string(receiverID.Type())
resourceAttributes[discovery.ReceiverTypeAttr] = receiverID.Type().String()
resourceAttributes[receiverRuleAttr] = rEntry.Rule
resourceAttributes[discovery.EndpointIDAttr] = "`id`"

Expand Down
2 changes: 1 addition & 1 deletion internal/receiver/discoveryreceiver/endpoint_tracker.go
Expand Up @@ -132,7 +132,7 @@ func endpointToPLogs(observerID component.ID, eventType string, endpoints []obse
rAttrs := rlog.Resource().Attributes()
rAttrs.PutStr(eventTypeAttr, eventType)
rAttrs.PutStr(observerNameAttr, observerID.Name())
rAttrs.PutStr(observerTypeAttr, string(observerID.Type()))
rAttrs.PutStr(observerTypeAttr, observerID.Type().String())
sl := rlog.ScopeLogs().AppendEmpty()
for _, endpoint := range endpoints {
logRecord := sl.LogRecords().AppendEmpty()
Expand Down
2 changes: 1 addition & 1 deletion internal/receiver/discoveryreceiver/factory.go
Expand Up @@ -29,7 +29,7 @@ const (

func NewFactory() receiver.Factory {
return receiver.NewFactory(
typeStr,
component.MustNewType(typeStr),
createDefaultConfig,
receiver.WithLogs(createLogsReceiver, component.StabilityLevelDevelopment))
}
Expand Down