Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Operator Docker image updater workflow improvements #1219

Merged
merged 2 commits into from Mar 20, 2024
Merged

[chore] Operator Docker image updater workflow improvements #1219

merged 2 commits into from Mar 20, 2024

Conversation

jvoravong
Copy link
Contributor

Description:

  • Updated our updater logic to adapt to the decentralization of Docker image storage by the OpenTelemetry Operator project, previously centralized at https://github.com/open-telemetry/opentelemetry-operator.
  • Ensured the correctness and existence of Docker image references used in operator auto-instrumentation by implementing validation checks.
  • Corrected an incorrect Docker image repository reference for nginx, changing it from autoinstrumentation-nginx to autoinstrumentation-apache-httpd to align with the upstream operator's default usage.

@jvoravong jvoravong requested review from a team as code owners March 13, 2024 14:58
@jvoravong
improve update operator docker images github workflow, extract docker…
48b1cea 
… image repos from the operator code, add validation to check new docker images exist
@jvoravong
run improved update-images-operator-otel.sh, fix bad repository refer…
5d787d6 
…ence for nginx
atoulme
atoulme approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvoravong jvoravong merged commit 4ba31b3 into main Mar 20, 2024
35 checks passed
@jvoravong jvoravong deleted the ghwf-fix branch March 20, 2024 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvoravong @atoulme