ignore span's scope version for java/nodejs tests #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2
force-pushed
the
ignore-trace-scopev
branch
from
a70e3af
to
32b8992
Compare
atoulme
approved these changes
Mar 12, 2024
|
I don't mind the pain caused by this as a reminder of updating our golden files, but this is ok I think. |
jvoravong
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ignore the scope version for the java/nodejs trace tests to unblock failing tests when automatic instrumentation library update PRs like this are created.
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: