Improve audio messages performance #5792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
Whenever audio attachment is playing there are a lot of unnecessary work done in
AudioWaveformProgressView.redrawSamples. On every audio progress update there are paths recreated forplayedShapeLayerandunplayedShapeLayer. In my solution I drawunplayedShapeLayerandplayedShapeLayeronce and further apply layer mask toplayedShapeLayerto show progress.AudioPlayertriggers update UI progress 20 times per second with Timer. I replaced timer withCADisplayLinkwhich allowed to reduce updates number per second and improve animation smoothness.Changes in 2 commits reduced CPU usage from 13% to 5% on my iPhone 12 (17.4.1).