Double tap message to show context menu #5772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the conversation view, long pressing a message presents the context view for that cell, allowing the user to add reactions, reply, delete the message, etc. To match the behavior that iOS users are accustomed to in iMessage, Signal should also allow double-tapping messages to present this menu. This can also be faster, since double-tapping doesn't have the same time delay that long press gestures have.
|
can't comment on the code, but this would be a good feature to have for sure great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
In the conversation view, long pressing a message presents the context view for that cell, allowing the user to add reactions, reply, delete the message, etc. To match the behavior that iOS users are accustomed to in iMessage, Signal should also allow double-tapping messages to present this menu. This can also be faster, since double-tapping doesn't have the same time delay that long press gestures have.
The code changes implemented all followed the same patterns as the tap and long press gesture recognizers on that view, so even though it's a few hundred lines it's mostly copy-paste from that and just tweaking the relevant parts.