Fix handling of PNG attachments for editor (addresses #5761) #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was the original logic of this list before the a977722 refactor (see https://github.com/frederickding/Signal-iOS/blob/ce18ac8d297440698313cbaa8c6c68c7ce02e559/SignalServiceKit/src/Util/MIMETypeUtil.m#L561-L569 pre-change), and other parts of the app assume this same logic (i.e., that the list includes GIFs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
These changes are meant to address #5761 by ensuring that
isAnimatedImagefor any PNG attachment is always determined by internal metadata, not whether it's in a list of MIME types, since PNGs can be either animated or not; and also to define the authoritative list of animated UTI types from those that are "definitely" animated after the a977722 refactor, not those that are "maybe" animated.