Ability to select all media in selection mode #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawisoon
approved these changes
Nov 17, 2023
Signal/src/ViewControllers/MediaGallery/MediaGalleryAccessoriesHelper.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: pawisoon <pawi552@gmail.com>
pawisoon
approved these changes
Nov 18, 2023
|
I hope that this welcome feature is added in short notice, since a lot of users are struggling with cleansing their media in Signal! |
|
Please merge this asap, a lot of people needs this |
|
Belated happy new year to the Signal team 😚🎉 How are we looking at getting this in? |
|
@harry-signal please please please can we get this merged? It's so frustratingly difficult and time consuming to manage storage space in Signal on iOS and this will be such a huge help for such a small change. |
|
+1 hoping for this to come asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
When deleting media it can take an extraordinary amount of time to select all items to delete as there is currently no way to select all. This is not only inconvenient but impacts user security when it may be necessary to delete all media from a conversation quickly without losing the text of the conversation. It's also a very common UI pattern to be able to select all items.
This PR adds a text button to the task bar allowing the user in one tap to select all the items in the view. When any items are selected the text of the buttons allows the user to select none.
The button is placed on the left away from the Delete button to prevent any accidental presses.
Screen.Recording.2023-10-16.at.23.13.24.mov