Update NavSidebar.scss to use z-index from _variables.scss #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, NavSidebar used a magic number for z-index. This commit changed this z-index to use $z-index-above-base from _variables.scss. Fixes signalapp#6633 where contextmenu--visible (part of ConversationPanel) is hidden behind NavSidebar.
2 tasks
|
Thanks for taking your time to review this PR, @josh-signal! |
|
Is this change still needed? We believe that we fixed the underlying issue here: 0f6d82d |
scottnonnenberg-signal
requested review from
jamiebuilds-signal
and removed request for
josh-signal
jamiebuilds-signal
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, NavSidebar used a magic number for z-index. This commit changed this z-index to use $z-index-above-base from _variables.scss.
Fixes #6633 where contextmenu--visible (part of ConversationPanel) is hidden behind NavSidebar.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #6633, where menu is hidden behind NavSidebar.
Previously, NavSidebar used a magic number for z-index.
This commit changed this z-index to use $z-index-above-base from _variables.scss.