Replace Audio Message Playback Rate Multipler close icon with multiplication symbol #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces with typographical "脳" character to reduce confusion with close icons elsewhere.
scottnonnenberg-signal
requested review from
ayumi-signal
and removed request for
josh-signal
|
We鈥檝e merged this internally, and it will be released in our next beta family. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces with typographical "脳" character to reduce confusion with close icons elsewhere.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
The current playback rate multiplier symbol is the x icon used throughout the app as the close symbol. This creates a component that looks like it has a close button, but cannot be closed.
This PR removes the close icon and replaces it with the typeface's multiplication symbol (unicode: U+00D7) instead!
Before
After
Caveats
If accepted, this change should also be applied to the iOS and Android apps... Something that may be beyond my abilities (not a Swift or Java programmer 馃槄)