Fix overflow in Chat Settings -> Conversation Color #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freddycibrian304
approved these changes
Apr 28, 2023
ArkadiuszMakosa
approved these changes
May 19, 2023
Relluem94
approved these changes
May 28, 2023
|
We’ve merged this internally, and it will be released in our next beta family. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #6359.
The
color-bubblemixin was adding 12px to the providedbubble-size, but the style of the grid element in the conversation color picker was not compensating for this. I have removed the 12px addition from the mixin and instead increased allbubble-sizesby 12px. This fixes the overflow issue in the color picker grid.I tested this on Mac OS with multiple window sizes.