Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation menu shows behind conversation list #6633

Closed
1 of 2 tasks
Meteor0id opened this issue Oct 5, 2023 · 3 comments · May be fixed by #6638
Closed
1 of 2 tasks

Conversation menu shows behind conversation list #6633

Meteor0id opened this issue Oct 5, 2023 · 3 comments · May be fixed by #6638
Labels
Should Be Fixed

Comments

@Meteor0id
Copy link

Meteor0id commented Oct 5, 2023 •
edited

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Steps to Reproduce

  1. step one
  2. step two
  3. step three

Actual Result:

Expected Result:

Screenshots

signla desktp z-index issue

Platform Info

Signal Version:

Operating System:

Linked Device Version:

Link to Debug Log
lvthanh03 added a commit to lvthanh03/Signal-Desktop that referenced this issue Oct 9, 2023
@lvthanh03
Update NavSidebar.scss to use z-index from _variables.scss
cfb1205 
Previously, NavSidebar used a magic number for z-index. This commit changed this z-index to use  $z-index-above-base from _variables.scss.

Fixes signalapp#6633 where contextmenu--visible (part of ConversationPanel) is hidden behind NavSidebar.
@lvthanh03 lvthanh03 mentioned this issue Oct 9, 2023
Open
7 tasks
@lvthanh03
Copy link
Contributor

Added an attempt to fix this in PR #6638.

Ishaan28malik added a commit to Ishaan28malik/Signal-Desktop that referenced this issue Oct 20, 2023
@Ishaan28malik
Update NavSidebar.scss
ccf389e 
updated the z-index of the dropdown signalapp#6633
@Ishaan28malik Ishaan28malik mentioned this issue Oct 20, 2023
Closed
7 tasks
@Ishaan28malik
Copy link

Added a PR here #6648

@scottnonnenberg-signal scottnonnenberg-signal changed the title z-index of drop down menu not high enough Conversation menu shows behind conversation list Oct 20, 2023
@scottnonnenberg-signal
Copy link
Contributor

We believe this was fixed here: 0f6d82d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Should Be Fixed
Milestone
No milestone
5 participants
@lvthanh03 @Ishaan28malik @Meteor0id @scottnonnenberg-signal @josh-signal