Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Taskbar Icon Badge Count not showing #4788

Closed
cakebarIO opened this issue Jan 11, 2021 · 6 comments · May be fixed by #4831
Closed

Windows Taskbar Icon Badge Count not showing #4788

cakebarIO opened this issue Jan 11, 2021 · 6 comments · May be fixed by #4831
Labels
Should Be Fixed

Comments

@cakebarIO
Copy link

Bug Description

When a user gets a new message on the Windows Desktop app, the badge count for an unread message does not display on/over the taskbar icon. Instead, when the user hovers over the Taskbar icon, the window preview shows with a "(1)" next to the window title => "Signal (1)"

Steps to Reproduce

-Desktop app is open.
-Notifications are turned on in Windows and in Signal
-User receives a new message.
-User sees notification banner from Action Center, however, there is no unread count badge on the taskbar Signal icon.

Expected Result:

There should be a badge on the taskbar icon indicating that there is a new message in Signal. Without it, a user does not know there is a new message in Signal without opening Signal.

Screenshots

Missing Taskbar Icon Badge for new messages

Platform Info

Signal Version:

1.39.4

Operating System:

Windows 10

Linked Device Version:

iOS14.3

Link to Debug Log

https://debuglogs.org/b2214129db6b30b10af89659b84461b0396671efd9ea210a378c32a20a7f2a4c
@rafd123
Copy link

rafd123 commented Jan 14, 2021

I'm one of the hoards coming from WhatsApp 😛 and I was about to write this very issue.

I believe the cause is that Windows, unlike other OSes, doesn't have a dedicated "badge count" API. Instead, Windows supports an overlay API. Electron supports the Windows overlay API, but it does mean that apps need to go out of their way to cater to Windows to show an unread count. See electron/electron#3148

Other Electron-based messaging apps (e.g. Slack, Teams, etc) seem to go through the trouble:

image

image

Digging into the code, it looks like it'd be pretty straightforward to pull off. I'd be willing to submit a PR.

@rafd123 rafd123 mentioned this issue Jan 14, 2021
Open
7 tasks
@GitHorst
Copy link

@rafd123 cool! any idea whether this will be pulled soon (or what's the hold-up)?

@rafd123
Copy link

rafd123 commented Feb 11, 2021

@GitHorst 🤷‍♂️ Not sure. It's the first time I've submitted a PR to this repo, and I'm not sure how the team works through their backlog of open PRs. I'm just chalking up the wait to how busy the team is given the surge in popularity.

@KommX
Copy link

KommX commented May 1, 2021

This seems to be available in v5.1.0-beta.5.

@KommX
Copy link

KommX commented Jun 29, 2021

@cakebarIO
Can this issue be closed?

@EvanHahn-Signal
Copy link
Contributor

I'm going to close this issue because it seems we've addressed this issue. Lemme know if that's wrong and I'll reopen.

@KeeJef KeeJef mentioned this issue Nov 15, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Should Be Fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows: show the unread count on the task bar (Fixes #4788) rafd123/Signal-Desktop
6 participants
@rafd123 @KommX @GitHorst @scottnonnenberg-signal @cakebarIO @EvanHahn-Signal