Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix racey dialog dismissal in PlacePickerActivity #13461

Closed

Commits on Mar 5, 2024

  1. Dismiss progress dialog onDestroy of PlacePickerActivity

    Avoids a race condition when dismiss is delayed because the progress bar
    hadn't been shown for long enough, while avoiding the flickering that
    would be caused when immediately dismissing the dialog earlier.
    fynngodau committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b93e6fb View commit details
    Browse the repository at this point in the history
  2. Avoid dismissing SimpleProgressDialog a second time

    In case `dismiss` (with delay) is called during an activity and the
    activity is consequently destroyed, and calls `dismissNow` in the
    process of its cleanup (i.e. in `onDestroy`), the delayed `dismiss`
    callback could still try to dismiss the dialog, causing an
    `IllegalArgumentException: View[…] not attached to window manager`.
    
    To avoid this faulty behavior, the delayed callbacks are removed
    whenever `dismissNow` is called.
    fynngodau committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    02a4247 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    10a0f64 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    42cee93 View commit details
    Browse the repository at this point in the history