UI glitches related to device linking #13371
Open
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-sys
force-pushed
the
linked_device_registration
branch
from
384f521
to
49cbf26
Compare
|
Hi @greyson-signal, you probably have overseen this PR and PR #13372. May you take a look at it? Thank you! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still no one had a look at my PR 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit(my two findings were not yet tracked AFAIK)Description
When linking a device, there is an action bar button to switch the camera. That button, however, did not vanish again if QR scan is complete (e.g if QR code was scanned or fragment was left by back button). Commit 704e560 hides the action bar button again as soon as the Fragment disappears.
The "+" fab in the linked device list was still using the old material2 style. Commit 384f521 changes it to use the current styles.
OT:
IMHO the screen looks quite empty if no device is linked yet. I would suggest adding a centered action button "link a device" instead of the "no device linked" text (and hiding the fab in this case). If this is wanted, I can provide a follow-up PR.