Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13299: Enable the camera only if permission is granted #13305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dautovicharis
Copy link
Contributor

@dautovicharis dautovicharis commented Dec 6, 2023

First time contributor checklist

Contributor checklist

  • Redmi Note 10 Pro, Android 13, MUI 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Issue

Fixes: #13299

Before fix

Test case 1: ✅

  • Settings
  • Profile image
  • Edit photo
  • Camera -> Allow permission
  • Back
  • Photo -> Allow permission

Result: The Camera button is visible on the photo picker screen.

Test case 2: ❌

  • Settings
  • Profile Image
  • Edit photo
  • Photo -> Allow permission

Result: The Camera button is visible(❌) on the photo picker screen.
Expected: The camera button should not be visible if the app doesn't have camera permission.

After fix

Test case 1: ✅

  • Settings
  • Profile image
  • Edit photo
  • Camera -> Allow permission
  • Back
  • Photo -> Allow permission

Result: The Camera button is visible on the photo picker screen.

Test case 2: ✅

  • Settings
  • Profile Image
  • Edit photo
  • Photo -> Allow permission

Result: The Camera button is not visible on the photo picker screen.

Both cases were tested several times with a clean app state.

Tested

Device Android Version Signal Version
Redmi Note 10 Pro Screenshot 2023-12-08 at 15 44 34 6.41.3

@dautovicharis dautovicharis changed the title Enable the camera only if permission is granted Fixes #13299: Enable the camera only if permission is granted Dec 6, 2023
Copy link

stale bot commented Apr 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 13, 2024
@alex-signal
Copy link
Contributor

I don't think we should be hiding the camera button, we should simply request the permission if the button is clicked, or direct the user to enable the permission in settings if they've permanently denied it.

@stale stale bot removed the wontfix label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Camera Permission Bug
3 participants