chore: switch to isort from reorder python imports #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] keep it simple with just `--profile black` argument - [x] update pull_request_template when asking for python-dateutil version - some engineers don't know to prefix `dateutil` with `python-` This is a premptive strike on sigmavirus24#1172 fix Signed-off-by: jmeridth <jmeridth@gmail.com>
for more information, see https://pre-commit.ci
|
Doesn't isort have a config for an import per line like reorder python imports? |
re-run black, hopefully get us to a non-conflict Signed-off-by: jmeridth <jmeridth@gmail.com>
for more information, see https://pre-commit.ci
|
That was not an issue locally: ✗ black src/github3/repos/branch.py
All done! ✨ 🍰 ✨
1 file left unchanged.But I'll take it fixing it and now this is passing. |
sigmavirus24
approved these changes
Mar 21, 2024
|
@sigmavirus24 nice change with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So many files changes. "Gotta rip the bandaid off" 😄
--profile blackargumentdateutilwithpython-This is a premptive strike on #1172 fix
Before opening a new issue, please search for a previously filed
issue to ensure you're not creating a duplicate.
Note Bug reports without the following will receive requests for these
details to be provided.
Version Information
Please provide:
The version of Python you're using (3.12.2)
The version of pip you used to install github3.py (24.0)
The version of github3.py (4.0.1), requests (2.31.0), uritemplate (4.1.1), and python-dateutil (2.9.0-post0) installed
Minimum Reproducible Example
Please provide an example of the code that generates the error you're seeing.
Exception information
What is exceptional about what you're seeing versus what you expected to see.