Add support for GitHub repository/organization secrets #1156
+6,668
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for organization and repository secrets. As these are part of the Actions API they are put into a new submodule github3.actions. Currently support OrganizationSecrets and RepositorySecrets. more info on the API at https://developer.github.com/v3/actions/secrets
MrBatschner
force-pushed
the
action-secrets
branch
from
18b1cbe
to
51a7151
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
MrBatschner
changed the title
|
Hey guys and @sigmavirus24, this PR is open for almost a year. I would be really glad if you could spare some time and give me some review feedback on it. |
sigmavirus24
requested changes
Apr 25, 2024
| .. attribute:: updated_at | ||
| The timestamp of when the secret was last updated |
There was a problem hiding this comment.
This must include documentation for visibility.
| super()._update_attributes(secret) | ||
| self.visibility = secret["visibility"] | ||
| if self.visibility == "selected": | ||
| self._selected_repos_url = secret["selected_repositories_url"] |
There was a problem hiding this comment.
Why is the URL attribute "private"? It should be public and named identically to the value in the JSON.
| list_key="repositories", | ||
| ) | ||
|
|
||
| def set_selected_repositories(self, repository_ids: typing.List[int]): |
There was a problem hiding this comment.
Prefer Sequence over List as a List[int] precludes Tuple[int] or any other sequence like data that Python will happily correctly serialize to a JSON Array
| url = "/".join([self._selected_repos_url, str(repository_id)]) | ||
| return self._boolean(self._put(url), 204, 409) | ||
|
|
||
| def delete_selected_repository(self, repository_id: int): |
There was a problem hiding this comment.
Suggested change
| def delete_selected_repository(self, repository_id: int): | |
| def remove_selected_repository(self, repository_id: int): |
Alternatively
These should be:
select_repositoriesselect_repositorydeselect_repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for organization and repository secrets. As these are part of the GitHub Actions API they are put into a new submodule
github3.actions.This PR does not support environment secrets as I believe this would better live in a dedicated Environment module.
This PR would potentially fix issue #1024.