Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added metrics and traces tabs #772

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: added metrics and traces tabs #772

wants to merge 1 commit into from
+694 −0

Conversation

navyayy
Copy link
Collaborator

@navyayy navyayy commented Apr 25, 2024

Description

Added Metrics and Traces tabs in Ingestion Tab

Testing

When selecting different options from the dropdown, it is displaying the correct details and also referring to the siglens docs.

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

@nkunal
Copy link
Contributor

nkunal commented Jun 5, 2024

@sonamgupta21 please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonamgupta21 sonamgupta21 Awaiting requested review from sonamgupta21 sonamgupta21 is a code owner

@nbhavana nbhavana Awaiting requested review from nbhavana nbhavana is a code owner

@sunitakawane sunitakawane Awaiting requested review from sunitakawane sunitakawane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@navyayy @nkunal