Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup for Alert Name Input on Logs Page #687

Closed
wants to merge 2 commits into from

Conversation

jqkim6
Copy link

@jqkim6 jqkim6 commented Mar 26, 2024

Description

On the logs page by add a popup that appears when the user clicks on the bell icon. The popup should include an input box allowing the user to enter the alert name.

image

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.44%. Comparing base (be02867) to head (9d7ca1b).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
+ Coverage    30.34%   30.44%   +0.09%     
===========================================
  Files          129      129              
  Lines        36172    36344     +172     
===========================================
+ Hits         10978    11065      +87     
- Misses       23880    23966      +86     
+ Partials      1314     1313       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nbhavana nbhavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pop up looks fine. Can you match the css for the pop up to match with other pop ups, like the one for adding a panel to dashboard.
Uploading image.png…

@AndrewHess
Copy link
Collaborator

@jqkim6 are you able to make the requested changes? If you don't plan to continue with this PR, please let us know so someone else can work on it

@nkunal nkunal closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants