-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #576 Disable the functionality to edit the default dashboard details #601
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #601 +/- ##
===========================================
- Coverage 30.42% 30.41% -0.02%
===========================================
Files 129 129
Lines 36387 36387
===========================================
- Hits 11071 11067 -4
- Misses 24003 24006 +3
- Partials 1313 1314 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Debasish Nandi <45676471+KiritoCyanPine@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonamgupta21 can you take a look at this PR when you get a chance?
We do not need tooltip for this change. We just need to make the input non-editable when the user tries to edit the field. |
Signed-off-by: Debasish Nandi <45676471+KiritoCyanPine@users.noreply.github.com>
understood, removed the tooltip functionality from PR. |
Signed-off-by: Sonam Gupta <71771131+sonamgupta21@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Default dashboards are not editable, the changes make the input fields
readonly
and displays a bootstraptooltip
stating 'default dashboards cannot be modified'.Fixes #576
Testing
Since the changes were made in javascript files, built the project and tested the UI.
Tests conducted
default dashboard:
created dashboard:
Checklist:
Before marking your pull request as ready for review, complete the following.
goimports -w .
. No go changes were involved.