Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #576 Disable the functionality to edit the default dashboard details #601

Merged
merged 17 commits into from
May 29, 2024

Conversation

KiritoCyanPine
Copy link
Contributor

@KiritoCyanPine KiritoCyanPine commented Feb 29, 2024

Description

Default dashboards are not editable, the changes make the input fields readonly and displays a bootstrap tooltip stating 'default dashboards cannot be modified'.

Fixes #576

Testing

Since the changes were made in javascript files, built the project and tested the UI.

Tests conducted

  • Tested default dashboards
  • Tested user-created dashboards
  • Tested the dashboards on Mobile view similarly. (*optional)

default dashboard:
Screenshot 2024-03-01 at 1 18 40 AM

created dashboard:
Screenshot 2024-03-01 at 1 19 16 AM

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w .. No go changes were involved.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.41%. Comparing base (0c5a648) to head (f9b1e7d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
- Coverage    30.42%   30.41%   -0.02%     
===========================================
  Files          129      129              
  Lines        36387    36387              
===========================================
- Hits         11071    11067       -4     
- Misses       24003    24006       +3     
- Partials      1313     1314       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Debasish Nandi <45676471+KiritoCyanPine@users.noreply.github.com>
@nbhavana nbhavana self-requested a review March 25, 2024 14:55
Copy link
Collaborator

@nbhavana nbhavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonamgupta21 can you take a look at this PR when you get a chance?

@nbhavana
Copy link
Collaborator

We do not need tooltip for this change. We just need to make the input non-editable when the user tries to edit the field.

Signed-off-by: Debasish Nandi <45676471+KiritoCyanPine@users.noreply.github.com>
@KiritoCyanPine
Copy link
Contributor Author

We do not need tooltip for this change. We just need to make the input non-editable when the user tries to edit the field.

understood, removed the tooltip functionality from PR.

Signed-off-by: Sonam Gupta <71771131+sonamgupta21@users.noreply.github.com>
Copy link
Collaborator

@sonamgupta21 sonamgupta21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonamgupta21 sonamgupta21 merged commit 7ac6920 into siglens:develop May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Disable the functionality to edit the default dashboard details
3 participants