-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added legend options for charts #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Legends Placement dropdown initially remains open and doesn't close when an option is selected.
- When clicking any option, changes should directly reflect on the chart. Currently, we have to rerun the query after selecting an option.
- Currently, the changes do not reflect if we save the dashboard and revisit it. We should store the legend-related values in the dashboard JSON.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #461 +/- ##
===========================================
+ Coverage 30.81% 30.82% +0.01%
===========================================
Files 127 127
Lines 35435 35435
===========================================
+ Hits 10918 10924 +6
+ Misses 23213 23208 -5
+ Partials 1304 1303 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of .fashttp.gz
files that you should remove from this PR. I think also the defaultDB
and querynodes
file changes/additions are not needed, right? If they're not needed, you should remove those from the PR
Description
Added customizable legend options such as Legend Modes (List, Table, Hidden), Legend Placements (Bottom, Right, left) and Legend Value Displays (Name, Value, Percentage) for dashboard panels, offering users the ability to choose.
Fixes #135
Checklist:
Before marking your pull request as ready for review, complete the following.
goimports -w .
.