Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added legend options for charts #461

Closed
wants to merge 18 commits into from

Conversation

PratikshaPatil77
Copy link
Contributor

Description

Added customizable legend options such as Legend Modes (List, Table, Hidden), Legend Placements (Bottom, Right, left) and Legend Value Displays (Name, Value, Percentage) for dashboard panels, offering users the ability to choose.

Fixes #135

Checklist:

Before marking your pull request as ready for review, complete the following.

  • [ x ] I have self-reviewed this PR.
  • [ x ] I have removed all print-debugging and commented-out code that should not be merged.
  • [ x ] I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

@PratikshaPatil77 PratikshaPatil77 marked this pull request as ready for review February 8, 2024 08:56
Copy link
Collaborator

@sonamgupta21 sonamgupta21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The Legends Placement dropdown initially remains open and doesn't close when an option is selected.
  2. When clicking any option, changes should directly reflect on the chart. Currently, we have to rerun the query after selecting an option.
  3. Currently, the changes do not reflect if we save the dashboard and revisit it. We should store the legend-related values in the dashboard JSON.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.82%. Comparing base (7f68694) to head (02745a8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #461      +/-   ##
===========================================
+ Coverage    30.81%   30.82%   +0.01%     
===========================================
  Files          127      127              
  Lines        35435    35435              
===========================================
+ Hits         10918    10924       +6     
+ Misses       23213    23208       -5     
+ Partials      1304     1303       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AndrewHess AndrewHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of .fashttp.gz files that you should remove from this PR. I think also the defaultDB and querynodes file changes/additions are not needed, right? If they're not needed, you should remove those from the PR

@nkunal nkunal closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Enhancement - Customizable Legends Options for Dashboard Panels
4 participants