FTX-886-kusto: fix issue where python datetime is not handled correctly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeTEEcee
commented
Sep 29, 2022
| return ", ".join(Cursor._escape(element) for element in value) | ||
| elif isinstance(value, datetime): | ||
| value = value.isoformat() | ||
| return "'{}'".format(value) |
There was a problem hiding this comment.
It looks like sqlalchemy by default replaces the T but I tested this with raw queries in the following formats and they all work with the server im connecting to right now.
"2020-01-01 01:01:01",
"2020-01-01 01:01",
"2020-01-01 01:01:01.000001",
"2020-01-01T01:01:01.000001",
"2020-01-01T01:01:01.000001",
"2020-01-01T01:01:01.000001+00:00",
"2020-01-01 01:01:01.000001+00:00",
"2020-01-01T01:01:01.000001+00:00Z",
"2020-01-01 01:01:01.000001+00:00Z"
Aside from making a PR to the original repo, I just try to communicate with the original source code authors and mention issues I see. This is a newer repo so I can only🙏 that the author is somewhat active.
It looks like the author put up an apache license: https://github.com/dodopizza/sqlalchemy-kusto/blob/main/LICENSE |
|
I did not want to go with a hacky fix on FTX because that made things look weirder. |
deeTEEcee
requested review from
clavoie-sightmachine
and removed request for
bremac
deeTEEcee
requested review from
ekauzlarich
and removed request for
ekauzlarich
ekauzlarich
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python datetime wasn't supported and I can only say the dialect is handling the parameter binds a bit differently. But it would take a lot more time for me to understand the sqlalchemy framework to handle this the proper way.
At the very least, I tested this and also saw how sqlalchemy was doing it so it should be fine.