New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add jsonStrings configuration #2642
base: master
Are you sure you want to change the base?
feat: Add jsonStrings configuration #2642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems perfectly legit to me. 💪
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2642 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 71 71
Lines 15727 15729 +2
Branches 1339 1342 +3
=======================================
+ Hits 14206 14208 +2
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey, @rubenmorim. Thanks 🚀 I believe the changes also fit the binary parser: node-mysql2/lib/parsers/binary_parser.js Line 62 in e536b41
For typings, we can include the option {
jsonStrings?: boolean;
}
Also, we could have a basic test for SELECT CAST('{"test": true}' AS JSON) AS json_result; |
lgtm, in addition to @wellwelwel comments - maybe also add a bit of documentation somewhere in https://github.com/sidorares/node-mysql2/tree/master/website/docs/documentation |
The added documentation also closes: |
Added configuration to support jsonStrings.
Check #1072 for more details about this feat