Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): reads should emit the dataset number for each dataset #2628

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Apr 26, 2024

This PR is a debug/fix of #2496, preserving all its commits.

Testing locally:

seq 1000 | xargs -I {} sh -c 'FILTER=test-multi-result-streaming npm run test || echo "Failure at iteration {}" >> failures.log'
  • I ran all the CI 3 times, just to make sure.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (9edfd72) to head (f98476d).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          71       71           
  Lines       15727    15727           
  Branches     1339     1339           
=======================================
  Hits        14206    14206           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.32% <100.00%> (ø)
compression-1 90.32% <100.00%> (ø)
tls-0 89.85% <100.00%> (ø)
tls-1 90.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title debug: PR #2496 fix(stream): reads should emit the dataset number for each dataset Apr 26, 2024
@wellwelwel wellwelwel marked this pull request as ready for review April 26, 2024 20:43
@wellwelwel wellwelwel added the mysqljs-mysql-incompatibilities Previously: feligxe-mysql-incompatibilities label Apr 27, 2024
@wellwelwel wellwelwel closed this May 6, 2024
@wellwelwel wellwelwel deleted the stream branch May 6, 2024 20:45
@wellwelwel wellwelwel restored the stream branch May 6, 2024 20:45
@wellwelwel wellwelwel reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysqljs-mysql-incompatibilities Previously: feligxe-mysql-incompatibilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants