Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same regex as mysqljs for changed rows #2518

Closed
wants to merge 1 commit into from

Conversation

KunZhou-at
Copy link
Contributor

@KunZhou-at KunZhou-at commented Mar 21, 2024

For INSERT ... ON DUPLICATE KEY UPDATE queries, the changed rows the EOF packet is named Duplicates instead of Changed. Here is the a sample message:

Records: 4  Duplicates: 0  Warnings: 0

I propose using the regex from the mysqljs project which also handles this situation.

@wellwelwel
Copy link
Collaborator

wellwelwel commented Mar 26, 2024

Thanks, @KunZhou-at 🚀

Can you include a test for these variations? Also, rebasing would be great for coverage tests 🙋🏻‍♂️

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@1aec4fd). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2518   +/-   ##
=========================================
  Coverage          ?   90.25%           
=========================================
  Files             ?       69           
  Lines             ?    14032           
  Branches          ?     1330           
=========================================
  Hits              ?    12664           
  Misses            ?     1368           
  Partials          ?        0           
Flag Coverage Δ
compression-0 90.25% <100.00%> (?)
compression-1 90.25% <100.00%> (?)
tls-0 89.71% <100.00%> (?)
tls-1 90.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel mentioned this pull request Apr 17, 2024
@KunZhou-at KunZhou-at closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants