Add lifecycle hooks, add typescript types, run prettier #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petehunt
force-pushed
the
add-lifecycle-hooks-and-typings
branch
2 times, most recently
from
1afae1b
to
8117511
Compare
|
Thanks Pete! Could you add prettier config you used so that future edits are consistent? |
petehunt
force-pushed
the
add-lifecycle-hooks-and-typings
branch
from
8117511
to
db762c6
Compare
|
Also if "onReloaded" hook is not part of webpack HMR api we need to add a line to readme ( |
|
will try to get to that this weekend :) |
|
@sidorares would you accept a PR to typescript-ify this project? |
yes, as long as it's still usable from vanilla js projects. I also have plans to add proper ejs hooks via vm.Module but never have enough time to do that and whenever I return all my research is outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey, thanks for a neat project. i'm messing around with building a hot reloading test runner and i needed some lifecycle hooks to know what was going on. i also added some types and ran it thru prettier.