Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gather plaform dns names #8700

Merged
merged 1 commit into from May 7, 2024
Merged

feat: gather plaform dns names #8700

merged 1 commit into from May 7, 2024

Conversation

sergelogvinov
Copy link
Sponsor Contributor

Retrieve the DNS names of instances from the platform metadata.

Pull Request

What? (description)

Why? (reasoning)

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@smira
Copy link
Member

smira commented May 7, 2024

@sergelogvinov looks like unit-tests are failing:

--- FAIL: TestParseMetadata (0.00s)
    --- FAIL: TestParseMetadata/V1 (0.00s)
        nocloud_test.go:103:

@smira smira self-assigned this May 7, 2024
@sergelogvinov
Copy link
Sponsor Contributor Author

Done @smira

@smira
Copy link
Member

smira commented May 7, 2024

/ok-to-test

@smira
Copy link
Member

smira commented May 7, 2024

@sergelogvinov make docs generate missing: https://ci.dev.talos-systems.io/siderolabs/talos/43146/1/7

@sergelogvinov
Copy link
Sponsor Contributor Author

Sorry for that.... fully forgot about this command.... )

@sergelogvinov sergelogvinov force-pushed the platform-dns branch 3 times, most recently from 408600a to 7659fa7 Compare May 7, 2024 17:54
@sergelogvinov @smira
feat: gather plaform dns names
f4d7b9d 
Retrieve the DNS names of instances from the platform metadata.

Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira
Copy link
Member

smira commented May 7, 2024

/m

@talos-bot talos-bot merged commit f4d7b9d into siderolabs:main May 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smira smira smira approved these changes

@frezbo frezbo frezbo approved these changes

Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sergelogvinov @smira @frezbo @talos-bot