Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v2.0.0.rc1 #462

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

markets
Copy link
Member

@markets markets commented Apr 15, 2024

Full diff: v1.12.0...master

@ondrejbartas @honzasterba Do you agree with this release? Since namespaces is a quite big feature (although retro-compatible with v1), I think it's good timing to start a new major. My idea is to launch it first as a release candidate and then, in some weeks, make the official v2 release.

@honzasterba
Copy link
Collaborator

I think versioning should be consistent with
major - breaking change
minor - new feature
patch - bugix
since this is a non breaking change a major release is not necessary, people not following the changelong may be scared to upgrade to major expecting extra work, my vote is to just bump minor

@markets
Copy link
Member Author

markets commented Apr 16, 2024

@honzasterba I agree, consistency with SemVer when releasing libs is something good. I just feel that this release is a little different compared to others, as we introduced significant changes and a couple of major features, so would like to mark a major bump.

I think I'm gonna wait some time and convert this to a draft for now, as it seems we have another changes in the cooking: #463.

Also, I'd like to review the current configuration system (and probably refactor? better docs?). As we have a couple of modules (Sidekiq::Optionsvs Sidekiq::Cron.configure) that are not 100% clear how they need to be used.

Thanks for the feedback!

@markets markets marked this pull request as draft April 16, 2024 18:55
@zedtux
Copy link
Contributor

zedtux commented May 15, 2024

Hey @markets 👋,

#463 is now closed. Any news regarding that configuration system refactoring?

Can you remove the draft mode on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants