Add support for specifying a custom Logical ID for the AWS::AppSync::GraphQLApi resource #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboure
reviewed
Nov 10, 2023
| @@ -104,6 +106,6 @@ export class Naming { | |||
| } | |||
|
|
|||
| getAuthenticationEmbeddedLamdbaName() { | |||
| return `${this.apiName}Authorizer`; | |||
| return `${this.config.name}Authorizer`; | |||
There was a problem hiding this comment.
Is this necessary?
Unless I am missing something, we probably could get away with having a
apiLogicalId that overrides getLogicalId.
The rest of the logical ids should be safe. i.e. They might be re-created but they are not stateful.
That would simplify everything.
bboure
reviewed
Nov 10, 2023
| @@ -12,6 +12,7 @@ export type AppSyncConfig = { | |||
| pipelineFunctions: Record<string, PipelineFunctionConfig>; | |||
| substitutions?: Substitutions; | |||
| xrayEnabled?: boolean; | |||
| logicalIdPrefix?: string; | |||
There was a problem hiding this comment.
As per my other comment, could this be named apiLogicalId?
bboure
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Thank you @manwaring
Could we also add documentation of when and how to use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring a possible solution to #617 by supporting a parameter to prefix the
AWS::AppSync::GraphQLApiLogical ID (instead of only supportingGraphQlApi)