feat: quite flag implemented #1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Thanks for the PR!
- It is spelled
quiet. - The printing of resource lists should not happen. The
Starting on ...is probably the only line from cargo-shuttle that should stay. - Read the issue description carefully. The flag also needs to be passed to the runtime to ignore prints on that side too.
Comment on lines
+1084
to
+1090
| if !quite_mode { | ||
| println!("{log_item}"); | ||
| } else { | ||
| if log_item.line.contains("ERROR") { | ||
| println!("{log_item}"); | ||
| } | ||
| } |
There was a problem hiding this comment.
We can't filter the runtime's lines like this. The goal is to supress shuttle's prints in cargo-shuttle and runtime. No lines from the user's program should be silenced.
There was a problem hiding this comment.
Okay.. Thanks : ), will try to do that.
dhruvdabhi101
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implemented
--quiteflag forcargo-shuttle runcommand.I added extra flag in
RunArgsstruct, then inspin_local_runfunction I checked if flag is true or not and accordingly I let print statement do the workCloses #1602
How has this been tested? (if applicable)
Tested Via running locally.
used this command
cargo run -p cargo-shuttle -- run --wd ../temp-project --quiteand output is something like this
