Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaky styles #2775

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Fix leaky styles #2775

wants to merge 1 commit into from

Conversation

drwpow
Copy link

@drwpow drwpow commented Mar 8, 2024

Changes

Fixes #2764. Supercedes #2765.

Also fixes user-generated content in landmark elements (nav, footer, etc.)

CleanShot 2024-03-08 at 10 19 31@2x

CleanShot 2024-03-08 at 10 19 42@2x

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: ffe28e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 5:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Mar 8, 2024 5:30pm

Copy link

vercel bot commented Mar 8, 2024

@drwpow is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

input,
[tabindex]:not([tabindex='-1']) {
.nextra-focusable,
.nextra-landmark a,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classnames I am not particular about; rename to anything else if they are more consistent with existing styles

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you! Sorry for delay, I will include your PR with my additional fixes in next v3 alpha release 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants