Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when page is a webpage, navlink cannot nav #2624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Map1en
Copy link

@Map1en Map1en commented Jan 14, 2024

When a page's meta information has an "href" field, the NavLink below the page will not have navigation functionality. If the href page is the last one, the navigation link will be for the current page. I have fixed this issue, and now the links can be clicked to navigate. However, I am unsure if I have correctly used the TypeScript type definitions.

Copy link

changeset-bot bot commented Jan 14, 2024

⚠️ No Changeset found

Latest commit: 81ab79b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 8:33am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2024 8:33am

Copy link

vercel bot commented Jan 14, 2024

@Map1en is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant