Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport support of APP_CACHE_DIR #3715

Closed
wants to merge 1 commit into from
Closed

Conversation

vrobert78
Copy link

1. Why is this change necessary?

We want to separate the cache directory from the /var folder on Platform.sh as /var is a NFS mount and cache a local one, and it triggers caching issues.
It was done for the 6.6, but it would be great to have it on the 6.5 too, hence this backport.

2. What does this change do, exactly?

It gives the possibility to define a new cache folder via APP_CACHE_DIR.

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

See 9997eb7

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Fails
🚫 The title `Backport support of APP_CACHE_DIR` does not match our requirements. Example: NEXT-00000 - My Title
Warnings
⚠️ The Pull Request doesn't contain any changelog file

@AydinHassan
Copy link
Contributor

hi @vrobert78 can you sign the CLA please :)

@AydinHassan AydinHassan self-assigned this May 17, 2024
@shyim
Copy link
Member

shyim commented May 17, 2024

I cherry-picked the PR internally from the trunk, it will be soon merged :) and hope to release it next week

@shyim shyim closed this May 17, 2024
@shyim shyim added Accepted and removed Incomplete labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants