Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Fix wrong address uses from cart address validator #3691

Closed
wants to merge 3 commits into from

Conversation

divide29
Copy link
Contributor

1. Why is this change necessary?

  1. The validator doesn't check the right addresses if the state is mandatory
  2. Message appearing in the storefront is confusing customers

2. What does this change do, exactly?

Just gets the right addresses in the validator

3. Describe each step to reproduce the issue or behaviour.

  1. Set the state as a mandatory field on registration.
  2. Open the cart
  3. See the two weird messages that are saying, that 2 addresses doesn't fulfill the minimum requirements.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@divide29 divide29 changed the title Patch 1 NEXT-00000 - Fix wrong address uses from cart address validator Apr 30, 2024
@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-36023

Please use this issue to track the state of your pull request.

@mstegmeyer
Copy link
Contributor

Your PR has been merged, thank you for your contribution 🎉 💙

Benedikt-Brunner pushed a commit to pickware/shopware-platform that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants