Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Changed media partial loaded event name #3690

Closed
wants to merge 1 commit into from

Conversation

En0Ma1259
Copy link
Contributor

1. Why is this change necessary?

MediaUrlLoader partial event is wrong

2. What does this change do, exactly?

Changed event name partial.media.loaded -> media.partial_loaded.
Event name will be generated like this $this->definition->getEntityName() . '.partial_loaded' in PartialEntityLoadedEvent

3. Describe each step to reproduce the issue or behaviour.

Load Partial Media

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-35785

Please use this issue to track the state of your pull request.

@En0Ma1259 En0Ma1259 deleted the bug/partial-event branch May 2, 2024 13:53
Benedikt-Brunner pushed a commit to pickware/shopware-platform that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants