feat: resolve extension parameters in compiler passes #3684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
CompilerPassConfigTrait
is used in some shopware compiler passes to read the configuration of the framework extension. The problem is, that parameters (e.g.'%env(DUMMY_ENV)%'
) will not get resolved. If the Symfony configuration class requires specific types, they may not be satisfied without the resolved values. This will lead to a crash of the kernel.2. What does this change do, exactly?
Before processing the extension config values in shopware compiler passes, resolve the parameters.
3. Describe each step to reproduce the issue or behaviour.
config/packages/messenger.yaml
bin/console
-> Kernel will fail to start with the errorInvalid type for path "framework.messenger.transports.test.retry_strategy.max_retries". Expected "int", but got "string".
4. Please link to the relevant issues (if any).
5. Checklist