Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Fix missing module error #3682

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 23, 2024

1. Why is this change necessary?

  • When the media folder overview is loaded and a module for a media folder is missing, an error occurs because it does not currently check whether the module exists before accessing it

2. What does this change do, exactly?

  • Changed sw-media-folder-item/index to check if the module exists before accessing it

3. Describe each step to reproduce the issue or behaviour.

  • Open the media folder overview with a missing module -> Error because the script is trying to access the manifest prop of the missing module

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants