Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-27720 - Fix missing user avatar media #3678

Closed
wants to merge 1 commit into from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 22, 2024

1. Why is this change necessary?

  • Currently the administration user can upload a avatar media for himself, but because of multiple missing associations the avatar never really shows up correctly
  • This PR fixes the avatar media by adding multiple missing associations to
    • The administration sidebar footer
    • The administration profile edit page
    • The administration User & Groups listing page
    • The administration User & Groups detail page

2. What does this change do, exactly?

  • Changed UserController to add the missing avatarMedia association
  • Changed sw-profile-index to load the missing user avatar on page load
  • Changed sw-users-permissions-user-listing to add the missing avatarMedia association
  • Changed sw-users-permissions-user-detail to load the missing user avatar on page load & provide media modal methods
  • Changed sw-users-permissions-user-detail twig template to include media modal content

3. Describe each step to reproduce the issue or behaviour.

  • Open the administration with a user who has a avatar media set
  • See that the media does not show up correctly in multiple places

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-27720

Please use this issue to track the state of your pull request.

@akf-bw akf-bw changed the title NEXT-00000 - Fix missing user avatar media NEXT-27720 - Fix missing user avatar media Apr 25, 2024
@akf-bw akf-bw deleted the fix-avatar-media branch May 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants