Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Fix sw-verify-user-modal autocomplete type #3673

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 18, 2024

1. Why is this change necessary?

  • Currently if you save the user profile / edit a user group or user the verify modal has a password input with the autocomplete type "new-password"
  • This wrong autocomplete types breaks all password managers and should be replaced by the correct "current-password" autocomplete type

2. What does this change do, exactly?

  • Changed the autocomplete type in sw-verify-user-modal.html.twig to current-password

3. Describe each step to reproduce the issue or behaviour.

  • Open the administration and edit your user profile

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants