Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Fix review filter #3672

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 17, 2024

1. Why is this change necessary?

  • Currently if you select a point amount as filter in a product review section and combine this filter with the review language filter the point amount selection disappears
  • This PR fixes this by including the missing points parameter also in the language switch form
  • Currently the replaceSelectors of the sortby form are different from the others and therefor look odd on a reload, this PR also fixes this form

2. What does this change do, exactly?

  • Changed review.html.twig to include the missing points parameter in the language filter form
  • Changed review.html.twig to adjust the replaceSelectors of sortby filter form to be similar to all other replaceSelectors

3. Describe each step to reproduce the issue or behaviour.

  • Select a point amount ( 1 - 5 ) in a product review section
  • Check the review language filter switch

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants